[core] Do not select template instances if their template arguments are invalid decls in the AST by smuzaffar · Pull Request #223 · cms-sw/root

smuzaffar · 2025-06-12T06:52:46Z

No description provided.

and only forward declared.

in presence of selected template instances with template arguments that are represented in the AST as invalid.

cmsbuild · 2025-06-12T06:53:07Z

A new Pull Request was created by @smuzaffar for branch cms/master/54116c111e.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-06-12T06:53:08Z

cms-bot internal usage

smuzaffar · 2025-06-12T06:53:21Z

test parameters:

full_cmssw = true

smuzaffar · 2025-06-12T06:53:37Z

please test with cms-sw/cmssw#48288 for CMSSW_15_1_ROOT6_X

cmsbuild · 2025-06-12T12:58:39Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65d853/46681/summary.html
COMMIT: e5b6bee
CMSSW: CMSSW_15_1_ROOT6_X_2025-06-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/223/46681/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_hltMenuContentToCSVs had ERRORS

Comparison Summary

Summary:

You potentially added 68 lines to the logs
Reco comparison results: 1055 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4050175
DQMHistoTests: Total failures: 876
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4049279
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

smuzaffar · 2025-06-12T13:19:51Z

please test with cms-sw/cmssw#48288 for CMSSW_15_1_ROOT6_X

cmsbuild · 2025-06-12T19:03:00Z

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65d853/46688/summary.html
COMMIT: e5b6bee
CMSSW: CMSSW_15_1_ROOT6_X_2025-06-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/223/46688/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65d853/46688/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65d853/46688/git-merge-result

Unit Tests

I found 5 errors in the following unit tests:

---> test TestDQMOnlineClient-ecal_dqm_sourceclient had ERRORS
---> test TestDQMOfflineConfiguration_150 had ERRORS
---> test TestDQMOfflineConfiguration_240 had ERRORS
and more ...

RelVals

1306.0

----- Begin Fatal Exception 12-Jun-2025 20:31:36 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing end ProcessBlock
   [1] Calling method for module DQMFileSaver/'dqmSaver'
   Additional Info:
      [a] Fatal Root Error: @SUB=TDirectoryFile::WriteTObject
The key name 'EBTTT Et spectrum Real Digis matched to spikes ' will be stored in file without the trailing blanks.

----- End Fatal Exception -------------------------------------------------

9.0

----- Begin Fatal Exception 12-Jun-2025 20:28:19 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing end ProcessBlock
   [1] Calling method for module DQMFileSaver/'dqmSaver'
   Additional Info:
      [a] Fatal Root Error: @SUB=TDirectoryFile::WriteTObject
The key name 'EBTTT Et spectrum Real Digis matched to spikes ' will be stored in file without the trailing blanks.

----- End Fatal Exception -------------------------------------------------

7.3

----- Begin Fatal Exception 12-Jun-2025 20:27:06 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing end ProcessBlock
   [1] Calling method for module DQMFileSaver/'dqmSaver'
   Additional Info:
      [a] Fatal Root Error: @SUB=TDirectoryFile::WriteTObject
The key name 'EBTTT Et spectrum Real Digis matched to spikes ' will be stored in file without the trailing blanks.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

smuzaffar · 2025-06-13T08:20:17Z

please test with cms-sw/cmssw#48312 for CMSSW_15_1_ROOT6_X

cmsbuild · 2025-06-13T15:34:55Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65d853/46704/summary.html
COMMIT: e5b6bee
CMSSW: CMSSW_15_1_ROOT6_X_2025-06-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/223/46704/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65d853/46704/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65d853/46704/git-merge-result

Unit Tests

I found 4 errors in the following unit tests:

---> test TestDQMOfflineConfiguration_150 had ERRORS
---> test TestDQMOfflineConfiguration_240 had ERRORS
---> test TestDQMOfflineConfiguration_230 had ERRORS
and more ...

Comparison Summary

Summary:

You potentially added 72 lines to the logs
Reco comparison results: 1055 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4050775
DQMHistoTests: Total failures: 991
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4049764
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.08000000000000006 KiB( 49 files compared)
DQMHistoSizes: changed ( 1000.0,... ): -0.002 KiB EcalEndcap/EETriggerTowerTask
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

smuzaffar · 2025-06-14T09:02:38Z

looks good, unit tests failures are unrelated to this change ( we have these unit tests failing in CMSSW IBs)

dpiparo added 4 commits June 10, 2025 15:08

[core] Skip selection of template instances if args are not defined

bbab160

and only forward declared.

[cling] Remove old debug printouts

6d09f75

[RN][NFC] Document behaviour change of dictionary generator

1c218f2

in presence of selected template instances with template arguments that are represented in the AST as invalid.

[Core] Add test for root-project#18982

e5b6bee

cmsbuild added orp-pending pending-signatures externals-pending tests-pending labels Jun 12, 2025

cmsbuild added tests-started requires-external and removed tests-pending labels Jun 12, 2025

smuzaffar changed the title ~~Fix 18982~~ [core] Do not select template instances if their template arguments are invalid decls in the AST Jun 12, 2025

smuzaffar mentioned this pull request Jun 12, 2025

[core] Do not select template instances if their template arguments are invalid decls in the AST root-project/root#19002

Merged

cmsbuild added tests-rejected and removed tests-started labels Jun 12, 2025

cmsbuild added tests-started and removed tests-rejected labels Jun 12, 2025

cmsbuild added tests-rejected and removed tests-started labels Jun 12, 2025

cmsbuild added tests-started and removed tests-rejected labels Jun 13, 2025

cmsbuild added tests-rejected and removed tests-started labels Jun 13, 2025

smuzaffar closed this Jun 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Do not select template instances if their template arguments are invalid decls in the AST#223

[core] Do not select template instances if their template arguments are invalid decls in the AST#223
smuzaffar wants to merge 4 commits intocms-sw:cms/master/54116c111efrom
dpiparo:fix_18982

smuzaffar commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025 •

edited

Loading

Uh oh!

smuzaffar commented Jun 12, 2025

Uh oh!

smuzaffar commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025

Uh oh!

smuzaffar commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025

Uh oh!

smuzaffar commented Jun 13, 2025

Uh oh!

cmsbuild commented Jun 13, 2025

Uh oh!

smuzaffar commented Jun 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

smuzaffar commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Jun 12, 2025

Uh oh!

smuzaffar commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025

Unit Tests

Comparison Summary

Uh oh!

smuzaffar commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025

Unit Tests

RelVals

Uh oh!

smuzaffar commented Jun 13, 2025

Uh oh!

cmsbuild commented Jun 13, 2025

Unit Tests

Comparison Summary

Uh oh!

smuzaffar commented Jun 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmsbuild commented Jun 12, 2025 •

edited

Loading